-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use upstream's cosmovisor #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested in local(Apple M1 pro), the following error was occurred.
~
11:44AM INF no upgrade binary found, beginning to download it module=cosmovisor
Error: cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any
11:44AM ERR error="cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any" module=cosmovisor
~
It's quite unlikely, but for the testing, I think it's a viable option. Now the test should succeed on your platform. |
zemyblue
approved these changes
Nov 12, 2022
dudong2
approved these changes
Nov 16, 2022
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would:
Motivation and context
The cosmovisor could be decoupled from the simapp, so we decided to use the upstream's.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml