Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove the incompatible field index=14 in TxResponse. #892

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 10, 2023

Description

remove the incompatible field index=14 in TxResponse.

Now all proto file of proto/cosmos are same with cosmos-sdk.

closes: #885

This PR is to reverse #526 .

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 10, 2023
@zemyblue zemyblue self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #892 (85b10c6) into main (e371872) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   62.31%   62.33%   +0.01%     
==========================================
  Files         653      653              
  Lines       79497    79471      -26     
==========================================
- Hits        49538    49537       -1     
+ Misses      27279    27254      -25     
  Partials     2680     2680              
Impacted Files Coverage Δ
types/abci.pb.go 0.51% <ø> (+<0.01%) ⬆️
types/result.go 76.64% <ø> (-0.14%) ⬇️

@zemyblue zemyblue merged commit 4776b03 into Finschia:main Feb 13, 2023
@zemyblue zemyblue deleted the feat/remove_txindex branch March 17, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefine cosmos proto changed in lbm to lbm's proto
3 participants