forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add event checking to TestStoreCode #63
Merged
da1suk8
merged 5 commits into
Finschia:main
from
da1suk8:test/check_event_TestStoreCode
Aug 10, 2023
Merged
test: add event checking to TestStoreCode #63
da1suk8
merged 5 commits into
Finschia:main
from
da1suk8:test/check_event_TestStoreCode
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 62.02% 61.99% -0.04%
==========================================
Files 80 80
Lines 9971 9971
==========================================
- Hits 6185 6182 -3
- Misses 3450 3452 +2
- Partials 336 337 +1 |
loloicci
reviewed
Aug 9, 2023
Co-authored-by: TAKASE Ryo <loloicci@loloicci.dev>
da1suk8
changed the title
test: added because there was no event check
test: add event checking to TestStoreCode
Aug 10, 2023
loloicci
approved these changes
Aug 10, 2023
dudong2
approved these changes
Aug 10, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestStoreCode
https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#msgstorecode
The event was not checked, so it was added to the test.
Also, here is a test on
instantiate_permission
.wasmd/x/wasm/types/tx_test.go
Lines 17 to 79 in dedcd9e
Motivation and context
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml