test: add test cases for empty request in each function #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
loloicci
suggested changes
Aug 10, 2023
loloicci
suggested changes
Aug 10, 2023
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
170210
force-pushed
the
fixup/emptyerror
branch
from
abb538c
to
03def6e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 61.99% 62.21% +0.21%
==========================================
Files 80 80
Lines 9971 9971
==========================================
+ Hits 6182 6203 +21
+ Misses 3452 3438 -14
+ Partials 337 330 -7 |
loloicci
previously approved these changes
Aug 10, 2023
Signed-off-by: 170210 <j170210@icloud.com>
da1suk8
approved these changes
Aug 10, 2023
loloicci
approved these changes
Aug 10, 2023
5 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test case in each function because we have not tested if request is empty.
This PR has added tests for empty request in 6 functions, except contractsByCode(contractsByCode has not been tested, it will be fixed in another PR )
Motivation and context
How has this been tested?
Unit tests
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml