Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases for invalid pagination key #66

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

170210
Copy link

@170210 170210 commented Aug 10, 2023

Description

Add a test case in some function because we have not tested if pagination key is invalid.
This PR has added tests for invalid pagination key in 3 functions, except contractsByCode(contractsByCode has not been tested, it will be fixed in another PR )

Motivation and context

How has this been tested?

Unit tests

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #66 (5002d81) into main (1f60af6) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 5002d81 differs from pull request most recent head cb46df2. Consider uploading reports for the commit cb46df2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   62.21%   62.09%   -0.13%     
==========================================
  Files          80       80              
  Lines        9971     9971              
==========================================
- Hits         6203     6191      -12     
- Misses       3438     3446       +8     
- Partials      330      334       +4     

see 2 files with indirect coverage changes

@170210 170210 marked this pull request as draft August 10, 2023 06:24
@170210 170210 self-assigned this Aug 10, 2023
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 marked this pull request as ready for review August 10, 2023 08:35
@170210 170210 merged commit a2607fb into Finschia:main Aug 14, 2023
7 checks passed
@170210 170210 deleted the fixup/invalid_request branch August 17, 2023 09:10
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants