forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test cases for invalid pagination key #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
August 10, 2023 06:00
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 62.21% 62.09% -0.13%
==========================================
Files 80 80
Lines 9971 9971
==========================================
- Hits 6203 6191 -12
- Misses 3438 3446 +8
- Partials 330 334 +4 |
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
170210
force-pushed
the
fixup/invalid_request
branch
from
August 10, 2023 07:10
287cb4e
to
5002d81
Compare
Signed-off-by: 170210 <j170210@icloud.com>
loloicci
reviewed
Aug 10, 2023
loloicci
approved these changes
Aug 10, 2023
dudong2
approved these changes
Aug 10, 2023
da1suk8
approved these changes
Aug 14, 2023
5 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test case in some function because we have not tested if pagination key is invalid.
This PR has added tests for invalid pagination key in 3 functions, except contractsByCode(contractsByCode has not been tested, it will be fixed in another PR )
Motivation and context
How has this been tested?
Unit tests
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml