Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test case to QueryInactiveContracts #82

Merged
merged 18 commits into from
Aug 22, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 17, 2023

Description

Add test case to QueryInactiveContracts

https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#queryinactivecontractsrequest
https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#queryinactivecontractsresponse

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b self-assigned this Aug 17, 2023
@Kynea0b Kynea0b changed the title test: add test case to QueryInactiveContracts test: add test case to QueryInactiveContracts Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #82 (31a7073) into main (40fa7c7) will increase coverage by 0.08%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   62.80%   62.89%   +0.08%     
==========================================
  Files          80       80              
  Lines        9966     9965       -1     
==========================================
+ Hits         6259     6267       +8     
+ Misses       3379     3373       -6     
+ Partials      328      325       -3     

see 3 files with indirect coverage changes

@Kynea0b Kynea0b marked this pull request as ready for review August 17, 2023 14:36
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the the order has become reversed as this pr, so I think we should add block setting.

x/wasmplus/keeper/querier_test.go Outdated Show resolved Hide resolved
x/wasmplus/keeper/querier_test.go Outdated Show resolved Hide resolved
x/wasmplus/keeper/querier_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
x/wasmplus/keeper/querier_test.go Outdated Show resolved Hide resolved
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b merged commit f36b389 into Finschia:main Aug 22, 2023
12 checks passed
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants