Merge 52b0969 into 4daf24b

FirebaseExtended · Mar 25, 2023 · b6d56e6 · b6d56e6
2 parents 4daf24b + 52b0969
commit b6d56e6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/lib/editor-client.js b/lib/editor-client.js
@@ -138,7 +138,11 @@ firepad.EditorClient = (function () {
     var compose = this.undoManager.undoStack.length > 0 &&
       inverse.shouldBeComposedWithInverted(last(this.undoManager.undoStack).wrapped);
     var inverseMeta = new SelfMeta(this.cursor, cursorBefore);
-    this.undoManager.add(new WrappedOperation(inverse, inverseMeta), compose);
+
+    if (this.editorAdapter.ready) {
+      this.undoManager.add(new WrappedOperation(inverse, inverseMeta), compose);
+    }
+
     this.applyClient(textOperation);
   };
 

diff --git a/lib/firepad.js b/lib/firepad.js
@@ -132,6 +132,8 @@ firepad.Firepad = (function(global) {
       if (defaultText && self.isHistoryEmpty()) {
         self.setText(defaultText);
       }
+
+      self.editorAdapter_.ready = true;
 
       self.trigger('ready');
     });

diff --git a/lib/text-operation.js b/lib/text-operation.js
@@ -452,6 +452,11 @@ firepad.TextOperation = (function () {
       // delete key.
       return (startB + simpleB.chars === startA) || startA === startB;
     }
+
+    // undo text replace in one go
+    if (simpleA.isDelete() && simpleB.isInsert()) {
+      return startA === startB;
+    }
 
     return false;
   };

diff --git a/lib/undo-manager.js b/lib/undo-manager.js
@@ -9,7 +9,7 @@ firepad.UndoManager = (function () {
 
   // Create a new UndoManager with an optional maximum history size.
   function UndoManager (maxItems) {
-    this.maxItems  = maxItems || 50;
+    this.maxItems  = maxItems || 500;
     this.state = NORMAL_STATE;
     this.dontCompose = false;
     this.undoStack = [];