Don't splat classes if using data converters #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one used Firestore data converters & built classes, these were getting thrown away when using
docData
/collectionData
.For now I've set use withIn thinking about it I decided to take a less opinionated approach here, a lighter touch for semver for folk using converters now.idField
etc. to throw, as there isn't really a point; since one could consumesnapshot.id
in the converter.Technically speaking this is a break, since if you converter returns a non object it won't be splatted any longer. E.g,
undefined
will returnundefined
rather than{}
if you usecollectionData
. But I consider this undefined behavior as we don't provide any guides here, WDYT @jhuleatt?Follow on:
Misc.: