Correction of the return values of the DatabaseInfo methods for determining the insert, read and delete operations #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort Firebird Server 2.0.
…per table since the last connection to the database
…per table since the last connection to the database. fixes FirebirdSQL#1157
…into DatabaseInfo
cincuranet
requested changes
Aug 26, 2024
| IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount(); | ||
| IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount(); | ||
|
|
||
| var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
| IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount(); | ||
| IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount(); | ||
|
|
||
| var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
| IDictionary<string, short> tableNameList = GetTableNameList(); | ||
| short tableIdTest = tableNameList["TEST"]; | ||
|
|
||
| var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
| if (counter > 0) | ||
| result.Add(keyValuePair.Key, counter); | ||
| } | ||
| else |
There was a problem hiding this comment.
Add }/{ for consistency sake.
There was a problem hiding this comment.
Does not look like it's here.
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
|
@cincuranet it appears that all requested changes have been addressed by @DevM900 (but weren't marked as "resolved"). Could you please review and proceed with the merge? |
cincuranet
requested changes
Nov 4, 2024
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
Outdated
Show resolved
Hide resolved
|
Not really. Some are still not addressed and going through it again I found some more. |
cincuranet
requested changes
Nov 5, 2024
| IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount(); | ||
| IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount(); | ||
|
|
||
| var fbCommand = new FbCommand("SELECT MAX(INT_FIELD) FROM TEST", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
| IDictionary<short, ulong> readSeqCount = dbInfo.GetReadSeqCount(); | ||
| IDictionary<short, ulong> readIdxCount = dbInfo.GetReadIdxCount(); | ||
|
|
||
| var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
| IDictionary<string, short> tableNameList = GetTableNameList(); | ||
| short tableIdTest = tableNameList["TEST"]; | ||
|
|
||
| var fbCommand = new FbCommand("INSERT INTO TEST (INT_FIELD) VALUES (900)", Connection); |
There was a problem hiding this comment.
Does not look like it's here.
|
|
||
| private IDictionary<string, short> GetTableNameList() | ||
| { | ||
| IDictionary<string, short> result = new Dictionary<string, short>(); |
There was a problem hiding this comment.
Does not look like it's here.
cincuranet
reviewed
Nov 6, 2024
| @@ -148,7 +148,7 @@ public async Task PerformanceAnalysis_UPDATE_Test() | |||
| Assert.That(readIdxCount[tableIdTest], Is.EqualTo(1)); | |||
| } | |||
|
|
|||
| IDictionary<short, ulong> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter) | |||
| async Task<IDictionary<short, ulong>> GetAffectedTables(IDictionary<short, ulong> statisticInfoBefore, IDictionary<short, ulong> statisticInfoAfter) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it possible to analyze the performance of queries.