Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotGenerator - type.(target)profile should replace base, not merge #965

Closed
wmrutten opened this issue Apr 29, 2019 · 1 comment
Closed

SnapshotGenerator - type.(target)profile should replace base, not merge #965

wmrutten opened this issue Apr 29, 2019 · 1 comment
Assignees
@wmrutten

Comments

@wmrutten
Copy link
Contributor

ElementDefinition.type.(target)profile elements need custom merging behavior:

  • Use the differential profiles if the list is not empty
  • Otherwise inherit the snapshot profile list
  • Do NOT merge differential & snapshot collections; this would prevent derived profiles from constraining the list of (target) profiles.
@wmrutten wmrutten added the bug label Apr 29, 2019
@wmrutten wmrutten self-assigned this Apr 29, 2019
wmrutten added a commit to wmrutten/fhir-net-api that referenced this issue Apr 29, 2019
@wmrutten
fix: FirelyTeam#965 SnapshotGenerator - type.(target)profile should r…
268e848 
…eplace base, not merge
@ewoutkramer
Copy link
Member

PR #966 is a fix for this.

ewoutkramer added a commit that referenced this issue May 21, 2019
@ewoutkramer
Merge pull request #966 from wmrutten/bugfix/965-SnapGen-ElementDefin…
4391421 
…itionProfiles

fix: #965 SnapshotGenerator - type.(target)profile should replace base, not merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmrutten wmrutten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewoutkramer @wmrutten