Fix/1229 snapshot generator slicing discriminator #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcovisserFurore
changed the base branch from
develop-stu3
to
develop-1.x/stu3
marcovisserFurore
approved these changes
Feb 3, 2020
marcovisserFurore
deleted the
fix/1229-snapshot-generator-slicing-discriminator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1229 . The issue suggests we can also solve this in the CopyTo POCO method, but since this happens only on ElementDef.Slicing.Discriminator, I fixed this using a workaround for now
I also included a unit test, which uses Moq. I didnt see an alternative, but I could be wrong. Please let me know if thats the case