Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amazon.aws module path in ansible v2.10 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

titanlien
Copy link

In order to support ansible v2.10.
Plan to release v1.0.0

@titanlien titanlien self-assigned this Oct 29, 2021
@titanlien titanlien requested review from cytopia and a team October 29, 2021 14:07
Copy link

@danvaida danvaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cytopia
Copy link
Member

cytopia commented Oct 30, 2021

Why not simply use the module directly?

https://docs.ansible.com/ansible/latest/collections/community/aws/ec2_eip_facts_module.html

This wasn't available at the time this role was written.

Can this be auto-bundled and used with a role (e.g.: replacing our plugin) and then also when using galaxy for this role that this is auto-fetched as well?

@danvaida
Copy link

danvaida commented Nov 1, 2021

Why not simply use the module directly?
https://docs.ansible.com/ansible/latest/collections/community/aws/ec2_eip_facts_module.html

This wasn't available at the time this role was written.

Can this be auto-bundled and used with a role (e.g.: replacing our plugin) and then also when using galaxy for this role that this is auto-fetched as well?

Indeed, I do remember that quite well. It's been quite a while since then :)

Given that we are already relying on the requirements.yml file to pull in the roles, I think it wouldn't be such a bother to add some extra lines in there like mentioned here.
For example:

---
roles:
  # Install a role from Ansible Galaxy.
  - name: geerlingguy.java
    version: 1.9.6

collections:
  # Install a collection from Ansible Galaxy.
  - name: geerlingguy.php_roles
    version: 0.9.3
    source: https://galaxy.ansible.com

This way, we don't need to download the collection separately using ansible-galaxy collection or other means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants