Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity overrides in local evaluation mode #89

Closed
khvn26 opened this issue Jan 30, 2024 · 0 comments · Fixed by #90
Closed

Identity overrides in local evaluation mode #89

khvn26 opened this issue Jan 30, 2024 · 0 comments · Fixed by #90
Assignees
@novakzaballa

Comments

@khvn26
Copy link
Member

khvn26 commented Jan 30, 2024 •
edited
Loading

  1. Extend the Environment model with the identity_overrides: List[IdentityModel] field.
  2. On environment update in local evaluation mode, store overrides so they're efficiently accessed by identifier.
  3. For GetIdentityFlagsFromDocument interface, use the storage above to retrieve the identity overrides. Fall back to a new IdentityModel instance if not found. If found, update traits with user-provided traits.

Refer to the following existing implementations:

Flagsmith/flagsmith-python-client#72
Flagsmith/flagsmith-java-client#142
Flagsmith/flagsmith-nodejs-client#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novakzaballa novakzaballa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Identity overrides in local evaluation mode Flagsmith/flagsmith-dotnet-client
2 participants
@khvn26 @novakzaballa