Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segments should support the 'IN' keyword #1595

Closed
4 tasks
sw-tracker opened this issue Nov 3, 2022 · 2 comments
Closed
4 tasks

Segments should support the 'IN' keyword #1595

sw-tracker opened this issue Nov 3, 2022 · 2 comments
Assignees
@khvn26
Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard sdk Issues related to the SDKs

Comments

@sw-tracker
Copy link

sw-tracker commented Nov 3, 2022 •
edited by matthewelwell

Hi @dabeeeenster ,

Our developers would like to be able to create a segment in which they can select an IN option from the drop-down and in the value they could enter a comma-separated list of strings/numbers.

image

Cheers,
Olga

Acceptance Criteria

  • Users are able to add a segment condition using the IN operator in the dashboard
  • Flags with a segment override using a segment with the IN operator are evaluated correctly via the Core API
  • Flags with a segment override using a segment with the IN operator are evaluated correctly via the Edge API
  • Flags with a segment override using a segment with the IN operator are evaluated correctly via local evaluation mode in all server side SDKs
@dabeeeenster dabeeeenster assigned EdsnLoor and unassigned EdsnLoor Nov 3, 2022
@dabeeeenster dabeeeenster added feature New feature or request front-end Issue related to the React Front End Dashboard api Issue related to the REST API sdk Issues related to the SDKs labels Nov 3, 2022
@dabeeeenster dabeeeenster changed the title Segment should support the 'IN' keyword Segments should support the 'IN' keyword Dec 16, 2022
@matthewelwell
Copy link
Contributor

matthewelwell commented Apr 11, 2023 •
edited by khvn26

This needs to be completed in the following places:

  • Core API
  • Flagsmith engine
  • Python SDK
  • PHP SDK
  • Java SDK
  • Node.js SDK
  • Elixir SDK
  • C# SDK
  • Ruby SDK
  • Go SDK
  • Rust SDK

@khvn26 khvn26 mentioned this issue Jul 5, 2023
Closed
1 task
@khvn26
Copy link
Member

khvn26 commented Jul 28, 2023

UI warning task: #2543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khvn26 khvn26

Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard sdk Issues related to the SDKs
Projects
Flagsmith Roadmap
Status: Done 2023
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

feature/-1595-segment-add-IN-option Flagsmith/flagsmith
6 participants
@dabeeeenster @khvn26 @matthewelwell @sw-tracker @novakzaballa @EdsnLoor