fix: Reading role permissions generates 500 error backend #3079
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
api/users/models.py
Outdated
| def get_user_roles(self): | ||
| user_roles = UserRole.objects.filter(user=self) | ||
| return user_roles |
There was a problem hiding this comment.
If settings.IS_RBAC_INSTALLED is not present then this method will throw an error. Maybe catch the exception and fire a custom error to stop it from looking like a random 500 error?
| if settings.IS_RBAC_INSTALLED: | ||
| roles = UserRoleSerializer(many=True, read_only=True, source="get_user_roles") |
There was a problem hiding this comment.
I don't really like the if-statement that leads to roles not being set on the serializer. Is this how we do it throughout the codebase? I feel like defaulting roles to None would look better.
There was a problem hiding this comment.
I don't think this is possible since UserRoleSerializer lives in RBAC.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
==========================================
- Coverage 95.89% 95.87% -0.02%
==========================================
Files 1039 1039
Lines 30721 30776 +55
==========================================
+ Hits 29459 29508 +49
- Misses 1262 1268 +6 ☔ View full report in Codecov by Sentry. |
| if settings.IS_RBAC_INSTALLED: | ||
| roles = UserRoleSerializer(many=True, read_only=True, source="get_user_roles") |
novakzaballa
deleted the
fix/reading-role-permissions-generates-500-error-be
branch
)" This reverts commit cee607a.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?