Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to delete multiple segment overrides at once #3100

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: Unable to delete multiple segment overrides at once #3100

merged 1 commit into from
Dec 7, 2023

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Dec 6, 2023 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Set isLoading state to false

How did you test this code?

  • Go to features -> Click a feature with segment overrides
  • Click on the segment overrides tab
  • Click the delete button and confirm it
  • Multiple segment overrides can now be deleted

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 2:48pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 2:48pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Dec 6, 2023 2:48pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited
Loading

Uffizzi Preview deployment-42273 was deleted.

@novakzaballa novakzaballa linked an issue Dec 6, 2023 that may be closed by this pull request
Unable to delete multiple segment overrides at once #3067
Closed
4 tasks
@kyle-ssg kyle-ssg added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 9e6e0ca Dec 7, 2023
18 checks passed
@kyle-ssg kyle-ssg deleted the fix/unable-to-delete-multiple-segment-overrides-at-once branch December 7, 2023 13:10
@dabeeeenster dabeeeenster mentioned this pull request Dec 7, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to delete multiple segment overrides at once
2 participants
@novakzaballa @kyle-ssg