Add ignore failed tests option to Flank #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
============================================
- Coverage 78.61% 78.60% -0.02%
- Complexity 661 664 +3
============================================
Files 113 113
Lines 2661 2673 +12
Branches 379 381 +2
============================================
+ Hits 2092 2101 +9
- Misses 321 322 +1
- Partials 248 250 +2 |
README.md
Outdated
| @@ -170,6 +170,9 @@ flank: | |||
|
|
|||
| ## The max time this test run can execute before it is cancelled (default: unlimited). | |||
| # run-timeout: 60m | |||
|
|
|||
| ## Set true to end with exit code 0 despite of failed matrices. False by default. | |||
There was a problem hiding this comment.
## Terminate with exit code 0 when there are failed tests. Useful for Fladle and other gradle plugins that don't expect the process to have a non-zero exit code. The JUnit XML is used to determine failure. (default: false)
What do you think of this more verbose description?
There was a problem hiding this comment.
Perfect, updated!
| @@ -56,7 +59,8 @@ class FlankYmlParams( | |||
| "project", | |||
| "local-result-dir", | |||
| "run-timeout", | |||
| "legacy-junit-result" | |||
| "legacy-junit-result", | |||
| "ignoreFailedTests" | |||
There was a problem hiding this comment.
I think the key is ignore-failed-tests
jan-goral
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602
Checklist