Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status page jobs updates #1083

Merged
merged 15 commits into from
Jun 11, 2024
Merged

Status page jobs updates #1083

merged 15 commits into from
Jun 11, 2024

Conversation

nrozanov
Copy link
Contributor

@nrozanov nrozanov commented Jun 4, 2024

Description

  • Merged 2 tables for scheduling and forecasting jobs to a single one
  • Added 'Queue' column
  • Renamed 'Asset id' column to 'Entity' and added entity name + entity type
  • Moved job_id to metadata
  • Added "Info" button for each row, clicking on which results in copying job metadata to a clipboard

Look & Feel

2 tables are merged into 1, info button is added

How to test

Add some scheduling / forecasting jobs, make some of them fail
Check you get both job types in new table, check clicking on "Info" button copies this job metadata

Further Improvements

Related Items


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Nikolai <nrozanov@iponweb.net>
@nrozanov nrozanov linked an issue Jun 4, 2024 that may be closed by this pull request
@nrozanov nrozanov requested a review from nhoening June 4, 2024 11:32
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but rather than the clipboard, I'd want to use a modal dialogue to open up with the information. Not sure how to format it nicely, maybe just pretty-printing if it is JSON.

We use modals in some other part of the UI, so you can steal code there.

flexmeasures/data/services/sensors.py Outdated Show resolved Hide resolved
Nikolai added 6 commits June 4, 2024 18:56
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
@nhoening
Copy link
Contributor

nhoening commented Jun 7, 2024

The modal is not (yet) working for me on Firefox and Chrome

Nikolai and others added 6 commits June 10, 2024 15:31
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great! There was one thing left (extra "x") but I resolved it myself.

flexmeasures/ui/templates/views/status.html Outdated Show resolved Hide resolved
@nhoening nhoening merged commit eeeb616 into main Jun 11, 2024
3 checks passed
@nhoening nhoening deleted the 1077-merge-job-status branch June 11, 2024 23:44
@nhoening nhoening added this to the 0.22.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge job status tables on status page and make them more informative
2 participants