-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status page jobs updates #1083
Status page jobs updates #1083
Conversation
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but rather than the clipboard, I'd want to use a modal dialogue to open up with the information. Not sure how to format it nicely, maybe just pretty-printing if it is JSON.
We use modals in some other part of the UI, so you can steal code there.
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
The modal is not (yet) working for me on Firefox and Chrome |
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nikolai <nrozanov@iponweb.net>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay great! There was one thing left (extra "x") but I resolved it myself.
Description
Look & Feel
2 tables are merged into 1, info button is added
How to test
Add some scheduling / forecasting jobs, make some of them fail
Check you get both job types in new table, check clicking on "Info" button copies this job metadata
Further Improvements
Related Items