-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit numpy version to fix ReadTheDocs build #682
Conversation
ci: run test on latest allowed dependency versions Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
df05ca3
to
0a871bb
Compare
Running pytest upgrading the dependencies I found another error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
For the testing of upgraded dependencies,
- I'm not sure we are now respecting the limits in app.in, as we just do an eager upgrade. I was thinking about a new make target
install-upgraded-deps
. - This prolongs our CI minute usage, per each push. Ideally, I'd only use this
upgrade
setting when a new PR is made, not on each push. Not sure how exactly, though.
You could also split the hotfix from the CI feature, if you want. |
On checking if we still support the latest versions of dependencies (the I see that we mostly run every action twice as we specify
However, as I'm checking a few PRs, this is not what is happening in our case. We should stop using
Then, maybe the best approach to use the Another interesting example is how to run a job when a PR is approved, but that works a little differently. Just an inspiration. |
This reverts commit 0a871bb.
…56.4 Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
a114325
to
e3c93ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- numba is not a first-level dependency of ours, so for a future Dev to release this limit, we should comment which library initially is responsible (likely the one that depends on numba, or even a specific version of numba).
- can you also make the PR description simpler again?
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
No changelog entry required imo. If anyone disagrees, feel free to place back the label. |
Should this be backported, actually? |
Closes #681
This PR limits the numpy version to <0.1.24 to make it compatible with
numba==0.56.4
.Please, let me know your thoughts on this :D