fix: instruct client browser to reload JS #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owser Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Sep 26, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement cache-busting to avoid the need to hard refresh the browser.
Look & Feel
Without this, the asset/sensor page will not load when a new function needs to be loaded from a local JS file. I ran into this when the
convertToCSVfunction was introduced as part of thejs/data-utils.jsfile. The browser caches these files, so we need to tell the browser to reload it. A common technique for this is cache-busting. In this PR I'm using the FlexMeasures version, so each new release (incl. local dev versions) leads to reloading the (locally imported) JS files.