Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): try highs solver again #863

Merged
merged 6 commits into from
Oct 2, 2023
Merged

fix(tests): try highs solver again #863

merged 6 commits into from
Oct 2, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Sep 27, 2023

Closes #805.

Lucky break, I guess.

@Flix6x
fix(tests): try highs solver again
3bd8438 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.17.0 milestone Sep 27, 2023
@Flix6x Flix6x self-assigned this Sep 27, 2023
@Flix6x
refactor: use default from main Config
f9d0332 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix: update docs and ci
c17bd1e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix: allow switching solvers, but actually restore the original one f…
2320876 
…or other tests

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
refactor: move fixture to local conftest
6236792 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Sep 28, 2023

After trying to remove the Cbc installation from the CI, I actually found one test (test_numerical_errors) with test cases for both HiGHS and Cbc. I realized that that test actually left the app config set to the last choice of solver for all tests that run after it, and then created a fixture (app_with_each_solver) to address this problem. We now have a fixture that could in principle be applied to other tests for which we'd like to test against both solvers (and is also easily extended to include yet other solver), but I consider such choices to be outside of the scope of this PR.

victorgarcia98
victorgarcia98 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

flexmeasures/data/models/planning/tests/conftest.py Show resolved Hide resolved
@Flix6x Flix6x merged commit 6870ac1 into main Oct 2, 2023
7 checks passed
@Flix6x Flix6x deleted the try-highs-on-python3.8 branch October 2, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorgarcia98 victorgarcia98 victorgarcia98 approved these changes

Assignees

@Flix6x Flix6x

Labels
Continuous Integration Scheduling
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

HiGHs solver in Python3.8
2 participants
@Flix6x @victorgarcia98