default loop count should be 1 #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixed an issue where a GIF in a browser would stop looping, but on the iOS mobile app it would not. I would maybe consider merging this unless it has been solved elsewhere |
|
@raphaelschaad I think #102 is a superset of this PR. You can close my PR if you will merge #102 . |
|
I had a look and left a detailed comment here. I don't see a difference between Chrome/Safari and FLAnimatedImage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Netscape Extension is not available in GIF, most web browsers play it only once.
But currently FLAnimatedImage plays it forever.
To fix this, need to check key
LoopCountexists in the dictionary. When it doesn't exist, default value should be 1.Can verify with this image: http://ww3.sinaimg.cn/mw1024/685b99a9gw1f0dbnnt07eg2053051mx5.gif
Following issue is related to this PR:
#156