Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roster files without extensions don't display anything #890

Open
TimothyHD opened this issue Jul 21, 2022 · 7 comments
Open

Roster files without extensions don't display anything #890

TimothyHD opened this issue Jul 21, 2022 · 7 comments

Comments

@TimothyHD
Copy link

When I load a .rosz file nothing happens.

@Floppy
Copy link
Owner

Floppy commented Jul 21, 2022

That's strange! Is it a valid Kill Team roster? Could you attach it here so I can take a look?

@TimothyHD
Copy link
Author

TimothyHD commented Jul 22, 2022 via email

@g3rg
Copy link
Collaborator

g3rg commented Jul 23, 2022

I can't see any files attached, wondering if github doesn't attach from email? Can you go to the issue on GitHub and attach to a comment?

I think error handling is something we can do better in Dataslate, it tends to just silently fail and not give any indication of what has happened if there's something it had an issue with in the roster file.

@TimothyHD
Copy link
Author

Here they are:
drive-download-20220724T173614Z-001.zip

@Floppy
Copy link
Owner

Floppy commented Jul 24, 2022

Thanks! I had a go, and indeed nothing happens. However, I noticed the files don't have an extension, and when I add a .ros or .rosz extension, it works fine! So, I guess something in Dataslate is relying on the extension being correct, which I guess it doesn't really need to.

@Floppy Floppy changed the title not working Roster fIles without extensions don't display Jul 24, 2022
@Floppy Floppy changed the title Roster fIles without extensions don't display Roster files without extensions don't display anything Jul 24, 2022
@g3rg
Copy link
Collaborator

g3rg commented Jul 24, 2022

You beat me to it by seconds @Floppy, was about to post pretty much the same thing.

@TimothyHD out of interest, do you know how the files ended up without the extension?

@TimothyHD
Copy link
Author

TimothyHD commented Jul 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants