Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass injector config and kras config #34

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Pass injector config and kras config #34

merged 1 commit into from
Jul 30, 2020

Conversation

carvinlo
Copy link
Contributor

Pass injector config and kras config, so that it can be referenced in the injector handle.

FlorianRappl
FlorianRappl reviewed Jul 26, 2020
View reviewed changes
Copy link
Owner

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be useful! Thanks for the PR! 🍻

src/server/injectors/script-injector.ts Outdated Show resolved Hide resolved
@carvinlo carvinlo force-pushed the amu/develop-script-injector branch from dd388f3 to a365b2f Compare July 27, 2020 04:57
FlorianRappl
FlorianRappl approved these changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the awesome contribution and sorry about my late reaction here 🍻!

@FlorianRappl FlorianRappl merged commit 70374b0 into FlorianRappl:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carvinlo @FlorianRappl