Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added arithmetic shift operations #47

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

0xflotus
Copy link
Contributor

part 2 of fix #44

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        45    +2     
  Lines          311       325   +14     
  Branches        49        49           
=========================================
+ Hits           311       325   +14     
Impacted Files Coverage Δ
source/bits/arithmetic-shift-left.ts 100.00% <100.00%> (ø)
source/bits/arithmetic-shift-right.ts 100.00% <100.00%> (ø)
source/bits/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ff2e6...5e8237a. Read the comment docs.

@0xflotus
Copy link
Contributor Author

oops, I swapped left shift with right shift. Fixed it a few minutes ago.

@FlorianWendelborn
Copy link
Owner

@0xflotus I merged the circular shift one as it was obvious how it should behave on arbitrary lengths of bits (doesn’t modify length). However, I’m really not sure about this one and if it’s more reasonable to keep the length or to decrease/increase it by amount

Base automatically changed from master to main March 17, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Operation Functionality
3 participants