Skip to content

Conversation

rrrooommmaaa
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa commented Mar 1, 2023

The fixed code doesn't process the signature attachment of a pubkey supplied by Protonmail
and hides it

close #3448

Also mocks text/plain and attachment rendering for GmailElementReplacer mock tests #4810

image


Tests (delete all except exactly one):

  • Tests added

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa
Copy link
Contributor Author

In extension's own inbox there is a duplicate block glitch
image
Let me create a separate test for it

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review March 3, 2023 12:42
@rrrooommmaaa rrrooommmaaa requested a review from sosnovsky as a code owner March 3, 2023 12:42
@rrrooommmaaa rrrooommmaaa enabled auto-merge (squash) March 3, 2023 12:57
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@rrrooommmaaa rrrooommmaaa merged commit 057faba into master Mar 3, 2023
@rrrooommmaaa rrrooommmaaa deleted the issue-3448-ignore-pubkey-signature-attachment branch March 3, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProtonMail: could not properly parse signed message

2 participants