Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing the Admin Settings General page resets the Platform Statstics token #2140

Closed
hardillb opened this issue May 15, 2023 · 0 comments · Fixed by #2141
Closed

Accessing the Admin Settings General page resets the Platform Statstics token #2140

hardillb opened this issue May 15, 2023 · 0 comments · Fixed by #2141
Assignees
@knolleary
Labels
backport bug Something isn't working priority:high High Priority size:XS - 1 Sizing estimation point
Milestone
1.8

Comments

@hardillb
Copy link
Contributor

Current Behavior

Loading the admin -> settings -> general page shows the platform statistics api token pop on each page load (and generates a new token each time)

Expected Behavior

If enabled the token should only be generated and shown at the point it is enabled, not each time the page is loaded

Steps To Reproduce

Enable stats api token
log out
log back in as admin
navigate to admin settings page

Environment

  • FlowForge version: 1.7.0
  • Node.js version: 16.x
  • npm version: 8.x
  • Platform/OS: Kube/Linux
  • Browser: Chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate
@hardillb hardillb added bug Something isn't working size:S - 2 Sizing estimation point labels May 15, 2023
@hardillb hardillb added this to the 1.8 milestone May 15, 2023
@knolleary knolleary added backport size:XS - 1 Sizing estimation point priority:high High Priority and removed size:S - 2 Sizing estimation point labels May 15, 2023
@knolleary knolleary self-assigned this May 15, 2023
hardillb added a commit that referenced this issue May 15, 2023
@hardillb
Don't regen token on every page load
4b6781d 
first pass at fix for #2140
@hardillb hardillb mentioned this issue May 15, 2023
Merged
11 tasks
@github-actions github-actions bot mentioned this issue May 15, 2023
Merged
11 tasks
github-actions bot pushed a commit that referenced this issue May 15, 2023
@hardillb
Don't regen token on every page load
5171eff 
first pass at fix for #2140
@MarianRaphael MarianRaphael moved this from Todo to Done in 🛠 Development May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knolleary knolleary

Labels
backport bug Something isn't working priority:high High Priority size:XS - 1 Sizing estimation point
Projects
🛠 Development
Archived in project
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Only Generate admin stats token when asked FlowFuse/flowfuse
2 participants
@knolleary @hardillb