-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large entries in audit log #4071
Comments
DesignI propose we approach this from the view of Env Vars (where the issue was raised) rather than a general/overall logging update since I believe there are unique properties e.g.
Example Before: Proposal 1 mock up:
|
There are certainly other places where the way the audit log captures all before/after state and reports it simply doesn't scale. The new edit snapshot log entries is another case - where we log the full before/after description - which could be multiple paragraphs of text. We don't want to have to fix each case individually; the default formatter for changes should just do a better job of it. I think hiding the specific changes by default is a good step. Then showing changes in a more structured way - rather than fully inline. |
Current Behavior
Following addition of support for multiline env vars #4069 it was noted that imports of large fields cause rather large audit log entries.
Example (zoomed out on a 4k monitor):
Expected Behavior
We should either drop logging of before and after values, log keys changed only or log a summary of changes
Steps To Reproduce
import large env file or add several large env vars to an instance/device
Environment
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate
The text was updated successfully, but these errors were encountered: