Remove unused export to JSON feature #1624
Conversation
|
Following a comment from @knolleary while we were firefighting on Friday night I'm going to suggest we hold off for a moment on this. |
|
For context - we found we had no way to take a complete backup of a project. This functionality would have been helpful at the time if it had existed. As part of the lessons learnt from Friday, we may want to prioritise restoring this functionality. An alternative is to add a Download option to snapshots - which would have its own set of benefits such as enabling 'offline' device agent. If we go that route, then we can and should strip out the unused code as per this PR. The point being, let's not remove a bunch of code today that we may, within days, decide we need to restore. |
|
Is there an issue to follow for the possible restoration? |
|
We are discussing Friday's incident here https://github.com/flowforge/CloudProject/issues/131 Actions yet to be determined. |
|
Thanks for the issue link. In general I'd strongly lean towards removing early, given restoring the feature is only a revert away. Unused code bloats the codebase, goes out of date introducing bugs, and slows down work, however if it's literally likely to be restored this week, let's leave it for now, and re-visit this PR next week. |
|
I'm going to say approve, we can pull it back from the history if we change our minds |
This was commented out as part of #547, it may be restored, but for now, let's remove the dead code, this PR can always be reverted down the line.