Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Danger" settings into the "General" tab #1637

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Move "Danger" settings into the "General" tab #1637

merged 3 commits into from
Feb 1, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Feb 1, 2023 •
edited
Loading

Description

Removed the "Danger" tab, and used the same page/component and embedded that into the "General" settings.

Screen.Recording.2023-02-01.at.11.24.08.mov

Related Issue(s)

Arose from discussion around #1610 where the "Danger" tab had grown beyond just dangerous things to change.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • [-] Configuration details
    • [-] Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt marked this pull request as ready for review February 1, 2023 12:11
@joepavitt joepavitt requested a review from Pezmc February 1, 2023 12:11
@joepavitt joepavitt added this to the 1.4 milestone Feb 1, 2023
@joepavitt joepavitt merged commit 537067b into main Feb 1, 2023
@joepavitt joepavitt deleted the move-project-settings branch February 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezmc Pezmc Pezmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🛠 Development
Archived in project
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@joepavitt @Pezmc