Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Posthog API Host configurable in flowforge.yml #1649

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Make Posthog API Host configurable in flowforge.yml #1649

merged 4 commits into from
Feb 3, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Feb 3, 2023 •
edited
Loading

Description

We had hard-coded the PostHog API host to be https://app.posthog.com. We are migrating our data to a different host, and so this needs to be configurable through the flowforge.yml.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • [-] Upgrade instructions
    • Configuration details
    • [-] Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt mentioned this pull request Feb 3, 2023
Closed
knolleary
knolleary requested changes Feb 3, 2023
View reviewed changes
docs/install/configuration.md Outdated Show resolved Hide resolved
forge/routes/ui/index.js Outdated Show resolved Hide resolved
joepavitt and others added 2 commits February 3, 2023 10:09
@joepavitt @knolleary
Update docs/install/configuration.md
147c4a9 
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@joepavitt @knolleary
Update forge/routes/ui/index.js
99eff68 
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@knolleary knolleary merged commit 18f9b6e into main Feb 3, 2023
@knolleary knolleary deleted the posthog-config branch February 3, 2023 10:42
@github-actions github-actions bot mentioned this pull request Feb 3, 2023
Merged
7 tasks
knolleary added a commit that referenced this pull request Feb 3, 2023
@knolleary
Merge pull request #1650 from flowforge/backport-1649
f1592c1 
Make Posthog API Host configurable in flowforge.yml (backport #1649)
@joepavitt joepavitt mentioned this pull request Feb 3, 2023
Merged
7 tasks
@github-actions github-actions bot mentioned this pull request Feb 3, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joepavitt @knolleary