Validate internal links that include # #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ZJvandeWeg
approved these changes
Feb 6, 2023
knolleary
added a commit
that referenced
this pull request
Feb 6, 2023
Validate internal links that include # (backport #1666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The link checking script was ignoring links to other pages with a
#in them. The PR fixes that.It does not validate the anchor is valid within the page, but at least checks the right file exists.
It also handles the case where a src link of
foo/bar#anchorcan be resolved by the existence of any one offoo/bar/README.md,foo/bar/index.mdorfoo/bar.md.This also fixes one broken link these updates helped to reveal.