Fix logic to disable housekeeper #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
reviewed
Feb 7, 2023
| @@ -34,7 +34,7 @@ module.exports = fp(async function (app, _opts, next) { | |||
| // Allow the housekeeper to be disabled - this allows the tests | |||
| // to run without fear the housekeeper may fire off a task at the same | |||
| // time. | |||
| if (!app.config.housekeeper) { | |||
| if (app.config.housekeeper === false) { | |||
There was a problem hiding this comment.
This was my mistake, I thought we'd want app.config.housekeeper being null or undefined to trigger it being disabled too (since the previous logic was !== true).
| @@ -34,7 +34,7 @@ module.exports = fp(async function (app, _opts, next) { | |||
| // Allow the housekeeper to be disabled - this allows the tests | |||
| // to run without fear the housekeeper may fire off a task at the same | |||
| // time. | |||
| if (!app.config.housekeeper) { | |||
| if (app.config.housekeeper === false) { | |||
There was a problem hiding this comment.
This was my mistake, I thought we'd want app.config.housekeeper being null or undefined to trigger it being disabled too (since the previous logic was !== true).
Pezmc
approved these changes
Feb 7, 2023
Pezmc
approved these changes
Feb 7, 2023
Pezmc
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Team Trials added the ability to disable the housekeeper thread so that the tests can run without fear of the housekeeper running stuff unexpectedly. The logic was a little aggressive and needs this fix to ensure it only gets disabled when intended.
Related Issue(s)
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel