-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Last Seen" device badge #1679
Conversation
Are you able to pull some stats to get an idea of the current distribution of last-seen for devices? |
Not sure I would be able to - they're not too widely used right now on FF Cloud, although with the provisioning work that @Steve-Mcl has done, that should hopefully change. They auto-ping every 30 seconds, so if they're connected, it'll be every 30 seconds that we hear from them |
The default ping interval is 60 seconds, but the user can configure that to something else that makes sense for their scenario - and there is a bit of jitter applied so it isn't always exactly 60 seconds - I think it can be +/- 5 seconds by default. If we assume most users stick to the defaults for now (until we address the broader solution outlined in the original issue), then I suggest:
But if you think green/red is sufficient, then combine yellow/red into one band. |
1. no see long timeSupposing a customer has distant remote (often offline due to environment) devices. e.g. 1 day unseen is perfectly ok and even expected due to "sleeping" over a weekend etc. They are going to see red entries with FMPoV,
2. sortingWill having a variable "last seen" text break the sorting (or make it unpredictable)? |
Agree there will be variation, i think as a first point of call, we want something in, then as a second phase, we can make this configurable. I have changed the "Over x hrs" to be more descriptive
It sorts on the |
Just in case you missed my point (or more likely I wasnt clear) - I agree colour threshold setting can/should be a future iteration however I was mostly trying to convey this... Only having 'over an hour ago' means I cannot judge if a device is simply sleeping or lost/broke/redundant. Having additional "time frames" means I can see if a device is actually redundant or lost. Something like...
Food for thought hopefully Joe. EDIT i should read more carefully
doh! |
😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
purrrfect
Description
Categorisation:
As implemented currently, shows as green if last seen within the last minute, otherwise red. Will likely want to add more text-based labels to cover more time periods beyond 1 hr ago.
Last SeenColourupdated table to: #1679 (comment)
Related Issue(s)
Closes #1599
Checklist