-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow signup page to be customised from admin settings #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo (fyi @iskerrett) Screen.Recording.2023-02-10.at.13.27.46.mov |
knolleary
commented
Feb 10, 2023
adding @Pezmc as reviewer given that I've since contributed directly to this PR |
expecting E2E tests to fail, just pushing progress to-date so that someone can sub in to finish if required ahead of Thursday as I'm blocked out in meetings for 1.5 days between now and then |
Pezmc
approved these changes
Feb 14, 2023
Verified in Staging #1621 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 1.3 we added
branding.account.signUpTopBanner
toflowforge.yml
as a way to insert custom text above the sign-up form.Via #1621 we have a requirement to insert longer text next to the sign-up form.
The downside of using
flowforge.yml
is that is requires a platform restart to pickup changes - making it hard to iterate.This PR allows the Admin to set the content for both pieces of HTML via the Admin Settings screen - if 'allow signup' is enabled.
If will still use the value of
branding.account.signUpTopBanner
from flowforge.yml unless overridden via this new setting. The only limitation being you cannot set it to blank via admin settings and have that override a value from the yml file (blank is interpreted as unset, so the yml file value gets used). The right answer being to remove it from flowforge.yml as a one-off admin task.The new setting
branding:account:signUpLeftBanner
does not, as of the current state of this PR, get displayed anywhere. That is over to @joepavitt to add.Related Issue(s)
#1621
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label