Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElapsedTime handles timezones and strings #1701

Merged
merged 2 commits into from
Feb 13, 2023
Merged

ElapsedTime handles timezones and strings #1701

merged 2 commits into from
Feb 13, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Feb 13, 2023

Description

ElapsedTime function should support strings in the to/from field and convert it to a date.

Related Issue(s)

Fixes #1700

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from hardillb February 13, 2023 15:08
@hardillb
Copy link
Contributor

UI Tests not happy

@hardillb hardillb merged commit c85ff90 into main Feb 13, 2023
@hardillb hardillb deleted the fix-elapsed-time branch February 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License Expiry Not Displaying
2 participants
@Pezmc @hardillb