Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated At and Delete Option for Team Library #1704

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Feb 14, 2023

Description

Screenshot 2023-02-14 at 18 10 13

Screenshot 2023-02-14 at 18 09 59

Screenshot 2023-02-14 at 18 10 03

Related Issue(s)

#1597

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

@Pezmc Pezmc requested a review from joepavitt February 14, 2023 17:12
Alert.emit('Copied to Clipboard.', 'confirmation')
Alerts.emit('Copied to Clipboard.', 'confirmation')
},
async deleteFile (file) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test coverage

@Pezmc Pezmc mentioned this pull request Feb 14, 2023
7 tasks
@Pezmc Pezmc marked this pull request as ready for review February 15, 2023 12:24
@Pezmc
Copy link
Contributor Author

Pezmc commented Feb 15, 2023

Test coverage and improving the UX around navigation are going to be completed as follow ups, ready for review @joepavitt!

This causes an issue when deleting a folder
@joepavitt
Copy link
Contributor

Screenshot 2023-02-15 at 16 31 03

getting 404s on the DELETE call unfortunately.

@joepavitt
Copy link
Contributor

works fine for any top-level elements, but nested elements/files seem to fail

@joepavitt joepavitt merged commit a2b7132 into main Feb 15, 2023
@joepavitt joepavitt deleted the feat-library-columns branch February 15, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants