Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Library: Navigation #1713

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Team Library: Navigation #1713

merged 4 commits into from
Feb 15, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Feb 15, 2023

Description

Re-works #1576 as part of #1597 to introduce page navigation.

This means that:

  • Users can browse to or bookmark certain URLs (e.g. team/test-team/library/folder/folder2/file.json)
  • The back/forward buttons work as expected in the browser

Additionally it tweaks the breadcrumbs to be clickable when viewing a file to return to the folder.

Screen.Recording.2023-02-15.at.20.19.06.mov

Related Issue(s)

#1597

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass - Tests pending
  • [-] Documentation has been updated
    • [-] Upgrade instructions
    • [-] Configuration details
    • [-] Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from joepavitt February 15, 2023 19:21
Base automatically changed from feat-library-columns to main February 15, 2023 20:34
@joepavitt
Copy link
Contributor

Just added the active file into the breadcrumb so you can see the filename you have open (without having to look into URL), this is also how it was before these changes were introduced, and think it reads better.

Screenshot 2023-02-15 at 20 43 30

@joepavitt joepavitt mentioned this pull request Feb 15, 2023
7 tasks
@joepavitt joepavitt merged commit 4d0d525 into main Feb 15, 2023
@joepavitt joepavitt deleted the feat-library-navigation-polish branch February 15, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants