Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky date-time test failures on GitHub #1728

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Feb 20, 2023

Description

It seems some of the test runners on GitHub use non-breaking spaces to separate parts of the time when formatted with locale:

May 17, 2022 at 1:39\u202fPM

This PR updates the relevant tests to normalize all whitespace, so the tests pass in all environments.

Related Issue(s)

Discovered first in #1727

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc merged commit 508f5cd into main Feb 20, 2023
@Pezmc Pezmc deleted the fix-date-time-tests branch February 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants