Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate all project functionality under instances #1765

Merged
merged 9 commits into from
Mar 3, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 2, 2023

Merge target is the feature branch for application instances as part of #1689: feat-1689-application-instances

Description

Duplicates almost all front end projects functionality, under /instances

  • The majority of these files are a naive copy and paste, with fixes for linting errors, and some find and replace for s/Project/Instance/.
  • Instances can be navigated to from the Project > Instances table (which only contains one entry for now)

This branch was rapidly becoming unwieldy, so I'm opening a PR now at a sensible pausing point, before continuing the work of #1718.

Next up:

  • Removing functionality from Projects that should remain exclusively under Instances
  • Removing functionality from this duplicate Instances that should remain under Projects (and move to Application at a later date)
Screen.Recording.2023-03-02.at.18.15.24.mov

Related Issue(s)

#1718

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 2, 2023 17:23
@Pezmc Pezmc changed the base branch from main to feat-1689-application-instances March 3, 2023 10:52
@knolleary knolleary merged commit 6e57538 into feat-1689-application-instances Mar 3, 2023
@knolleary knolleary deleted the feat-1718-instances branch March 3, 2023 15:12
@Pezmc Pezmc mentioned this pull request Mar 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants