Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Instances: Delete Application #1811

Merged
merged 9 commits into from
Mar 14, 2023
Merged

Application Instances: Delete Application #1811

merged 9 commits into from
Mar 14, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 13, 2023

Description

A quick minimally shippable version for deleting an application (which currently is the same as deleting an instance).

"Danger" section in Application settings

Screenshot 2023-03-13 at 18 38 03

New Modal

Screenshot 2023-03-13 at 18 38 08

Existing Modal for Instances

Accessed from Instance > Settings > Danger page or the instances list on Application > Instances

Screenshot 2023-03-13 at 18 37 53

Related Issue(s)

#1810

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 13, 2023 17:48
@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 14, 2023

Looking into why this is failing again...

@Pezmc Pezmc merged commit a0fcf9f into main Mar 14, 2023
@Pezmc Pezmc deleted the feat-1810-delete-application branch March 14, 2023 11:17
@Pezmc Pezmc mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary Awaiting requested review from knolleary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pezmc