Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Re-write imports to be ES6 #1909

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Chore: Re-write imports to be ES6 #1909

merged 7 commits into from
Apr 4, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Apr 3, 2023 •
edited
Loading

Description

Re-writes all use of '@/' in the front-end codebase to use a relative import.

Please see reasoning in #1908

Was replaced using a script.

Related Issue(s)

Part of #1908

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Apr 3, 2023 that may be closed by this pull request
Remove use of webpack alias #1908
Closed
@Pezmc
Copy link
Contributor Author

Pezmc commented Apr 3, 2023

Rebased onto main to pull in #1846 so 356516c can enable a lint rule that requires all files to resolve.

Steve-Mcl
Steve-Mcl reviewed Apr 4, 2023
View reviewed changes
.eslintrc Show resolved Hide resolved
@Steve-Mcl Steve-Mcl self-requested a review April 4, 2023 07:46
Steve-Mcl
Steve-Mcl approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pezmc I am personally very happy to see the improvements to development experience this PR brings. Review looks good. Cant spot any missing refs & tests pass - gets my approval.

@Pezmc Pezmc merged commit 05e3604 into main Apr 4, 2023
@Pezmc Pezmc deleted the chore-rewrite-imports branch April 4, 2023 07:52
@Pezmc
Copy link
Contributor Author

Pezmc commented Apr 4, 2023

Joe and I spoke over this in a call and he's happy to move forward, even if it means slightly less convenient imports.

@Steve-Mcl
Copy link
Contributor

@Pezmc might be worth a mention in dev channel (do a pull on main) due to many small changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

@joepavitt joepavitt Awaiting requested review from joepavitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of webpack alias
2 participants
@Pezmc @Steve-Mcl