Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve feedback when trying to delete non-empty application #1976

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Improve feedback when trying to delete non-empty application #1976

merged 2 commits into from
Apr 12, 2023

Conversation

knolleary
Copy link
Member

Fixes #1974

  1. improves the wording that gets shown to the user
  2. gives the user more than 3 seconds to read the message

@knolleary
Copy link
Member Author

  1. Fixes the docs for alert.emit to make it clear the units are ms not s as it currently implied

@joepavitt
Copy link
Contributor

Code changes are good - waiting for tests to pass before merging

@knolleary knolleary merged commit a39fea8 into main Apr 12, 2023
@knolleary knolleary deleted the 1974-remove-projects-message branch April 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast message when trying to delete an App with instances says 'projects'
2 participants
@knolleary @joepavitt