Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework more tests to minimise app reinitialisation #2023

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

knolleary
Copy link
Member

Part of #2004

Some more test refactoring to minimise reinitialisation of the forge app.

When running these tests locally, it reduces the runtime from 60s to 12s.

@Steve-Mcl
Copy link
Contributor

getting sooo much better. 6m for default test run.

Quick Question: Have you tried running the odd random, middle of the pack test on its own (using VSCode Mocha Test plugin or editing the file with .only)?

@knolleary
Copy link
Member Author

Quick Question: Have you tried running the odd random, middle of the pack test on its own (using VSCode Mocha Test plugin or editing the file with .only)?

I haven't done that for every single test, but it is certainly one of the things I do when I need to isolate a test to figure out what its requirements are on the forge app to ensure it gets a clear start.

@knolleary
Copy link
Member Author

Odd that postgres is still getting a genuine test failure. I thought I had squashed that.

@knolleary
Copy link
Member Author

@Steve-Mcl tests now passing - ready for review/merge

@Steve-Mcl Steve-Mcl merged commit b56b3aa into main Apr 20, 2023
@Steve-Mcl Steve-Mcl deleted the 2004-more-test-rework branch April 20, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants