Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against users without team edit accessing billing #2045

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Apr 26, 2023

Description

Fixes two issues:

  • Prevents a request failed error when navigating to a team where a user does not have edit team access
  • Blocks the /billing pages entirely from users without team edit access (previously just hidden in the UI)

Related Issue(s)

Fix #1845

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass - Not possible to easily test request is not being made
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from hardillb April 26, 2023 07:48
@hardillb hardillb merged commit 9c79cfd into main Apr 26, 2023
@hardillb hardillb deleted the fix-1845-billing-auth-error branch April 26, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing to a team as a member shows unauthorized error
2 participants