Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Elapsed time between two dates #2048

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix: Elapsed time between two dates #2048

merged 1 commit into from
Apr 27, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Apr 26, 2023

Description

Fixes root cause of issue in #1895 where displayed days left on license displayed too different values.

Issue was the elapsed time module not including weeks in the math.

Related Issue(s)

Fixes #1895

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc merged commit 5b2cabe into main Apr 27, 2023
@Pezmc Pezmc deleted the fix-1895-elapsed-time-bug branch April 27, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

@Steve-Mcl Steve-Mcl Awaiting requested review from Steve-Mcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect number of days displayed when adding a new license
2 participants
@Pezmc @joepavitt