Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Last Seen" chart for filtering Devices #2058

Merged
merged 9 commits into from
May 3, 2023
Merged

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Apr 27, 2023

Description

  • Moves some of the Device Status bucketing logic into a service, as this is now shared across multiple screens. This contains logic to bucket to a css class & label pair.
  • Adds a new "DeviceStatusBar" component which is driven by a property and list of all devices.
Screen.Recording.2023-04-28.at.12.23.06.mov

Considerations:

  • Driven by the existing devices API call, which will hit device pagination, may need separate API call. Currently, we are dependent upon having the device id's in order to set the filter at the top level. This is because (in the example of status this is not a property on the device object directly, but computed within the filtering)

Related Issue(s)

First part of #1937

Checklist

@joepavitt joepavitt changed the title Add "Last Seen" chart for filtering Add "Last Seen" chart for filtering Devices Apr 27, 2023
@MarianRaphael MarianRaphael linked an issue Apr 27, 2023 that may be closed by this pull request
@joepavitt joepavitt marked this pull request as ready for review April 28, 2023 12:52
@joepavitt joepavitt requested a review from Pezmc April 28, 2023 12:53
frontend/src/components/DevicesBrowser.vue Outdated Show resolved Hide resolved
frontend/src/components/DevicesBrowser.vue Show resolved Hide resolved
@joepavitt joepavitt requested a review from Pezmc May 2, 2023 15:34
@joepavitt joepavitt merged commit 0ef0151 into main May 3, 2023
@joepavitt joepavitt deleted the 1937-device-status-chart branch May 3, 2023 13:40
@knolleary knolleary linked an issue May 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Design "Devices" view to add Visual Insights
2 participants