Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure device-agent 0.7.0 messages are displayed #2079

Merged
merged 3 commits into from
May 5, 2023
Merged

Ensure device-agent 0.7.0 messages are displayed #2079

merged 3 commits into from
May 5, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented May 3, 2023

part of #2074

Description

ensure we convert any log message payload to a string before trying to display it, this should only be needed for device agent v0.7.0

Related Issue(s)

#2074

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.7 milestone May 3, 2023
@hardillb hardillb self-assigned this May 3, 2023
@hardillb hardillb requested a review from joepavitt May 3, 2023 12:09
@hardillb hardillb mentioned this pull request May 3, 2023
Closed
@joepavitt joepavitt merged commit 93fddcc into main May 5, 2023
@joepavitt joepavitt deleted the device-log-error-fix branch May 5, 2023 07:39
@knolleary knolleary linked an issue May 5, 2023 that may be closed by this pull request
Device logs not showing when expected in FlowForge #2074
Closed
@knolleary knolleary mentioned this pull request May 11, 2023
Merged
11 tasks
@github-actions github-actions bot mentioned this pull request May 11, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

Device logs not showing when expected in FlowForge
2 participants
@hardillb @joepavitt