Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the favicon #2096

Merged
merged 1 commit into from
May 9, 2023
Merged

Updated the favicon #2096

merged 1 commit into from
May 9, 2023

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented May 5, 2023

Description

Updated the favicon

Related Issue(s)

700

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Yndira-E Yndira-E requested a review from joepavitt May 5, 2023 11:07
@Yndira-E Yndira-E linked an issue May 5, 2023 that may be closed by this pull request
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iteration on the favicion in order to differentiate between Product & Website tabs. This is likely to change again in the future as I'm not 100% convinced this is the correct solution, but it's better than what we have now in that it's distinguishable from website, so moving this forward.

@joepavitt joepavitt merged commit 6d66674 into main May 9, 2023
@joepavitt joepavitt deleted the 700-favicon-platform branch May 9, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon platform
2 participants