Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit log entries for developer mode, remote editor access and device snapshot #2119

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented May 10, 2023

Description

Adds audit log entries for developer mode, remote editor access and device snapshot

Team Log:

Developer Mode Enabled
Developer Mode Disabled
Remote Access Enabled
Remote Access Disabled

Project Log:

Device Snapshot Created

image

image

Adds tests for new loggers:

  • Provides a logger for creating a snapshot from a project device
  • Provides a logger for when developer mode is enabled for a device in a team
  • Provides a logger for when developer mode is disabled for a device in a team
  • Provides a logger for when remote access is enabled for a device in a team
  • Provides a logger for when remote access is disabled for a device in a team

image
image

Related Issue(s)

#2115

Checklist

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue May 10, 2023 that may be closed by this pull request
@Steve-Mcl Steve-Mcl marked this pull request as ready for review May 10, 2023 10:45
@joepavitt joepavitt self-requested a review May 10, 2023 10:47
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned as a single comment - think the nested audit log approach we have means it should be:

developerMode.enabled

rather than

developerModeEnabled

It's picky, but consistency is key and all that...

@Steve-Mcl Steve-Mcl requested a review from joepavitt May 10, 2023 11:06
Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to the outstanding tests running - all looks good to me

@Steve-Mcl Steve-Mcl merged commit 82db8e1 into main May 10, 2023
@Steve-Mcl Steve-Mcl deleted the 2115-audit-log-entries-for-developer-mode-and-remote-editor-access branch May 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log entries for developer mode and remote editor access
2 participants